Skip to content

DNS-Challenge: fix DESec.io -> Fix return values in add txt record function #6602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

DNS-Challenge: fix DESec.io -> Fix return values in add txt record function #6602

wants to merge 2 commits into from

Conversation

@rICTx-T1D
Copy link

@rICTx-T1D rICTx-T1D commented Nov 5, 2025

Changed return values for error handling in txt record addition. DESec.io create txt-record but PUT was indicated as failed

Test pass OK

@rICTx-T1D
Fix return values in add txt record function
a14d034 
Changed return values for error handling in txt record addition.
DESec.io create txt-record but PUT was indicated as failed
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Welcome
READ ME !!!!!
Read me !!!!!!
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please read the DNS API Dev Guide.
You MUST pass the DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
Please also make sure to add/update the usage here: https://github.com/acmesh-official/acme.sh/wiki/dnsapi2
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@rICTx-T1D rICTx-T1D changed the base branch from master to dev November 5, 2025 18:43
@rICTx-T1D
Copy link
Author

rICTx-T1D commented Nov 5, 2025

#2180

@Neilpang
Copy link
Member

Neilpang commented Nov 9, 2025

why return 0 when there is add error ?

@rICTx-T1D
Copy link
Author

rICTx-T1D commented Nov 18, 2025 •
edited
Loading

why return 0 when there is add error ?

When return 1 or higher than 0, acme think its not okay and delete the fresh created dns record. DESec.io has return error but the record was successfully created and is displaying on GUI.

Maybe the API doesn't retturn correct status code. But this is out over our scope here.

@Neilpang
Copy link
Member

Neilpang commented Nov 18, 2025

https://github.com/acmesh-official/acme.sh/wiki/DNS-API-Test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rICTx-T1D @Neilpang